[Webkit-unassigned] [Bug 61336] New: REGRESSION: Media elements fail to fire ended event after changing src

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61336

           Summary: REGRESSION: Media elements fail to fire ended event
                    after changing src
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Media Elements
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: scherkus at chromium.org
                CC: eric.carlson at apple.com


Bisected builds all the way down to a seemingly innocuous change:
http://trac.webkit.org/browser/trunk/Source/WebCore/html/HTMLMediaElement.cpp?rev=85488

Repro'd on Safari/Mac, Chromium/Mac and Chromium/Linux... I'm wagering it affects all ports since it's seems to be MediaPlayer agnostic.

What was happening is that a call to m_player->seek(0) triggers an immediate call to HTMLMediaElement::mediaPlayerTimeChanged(), which clears the m_sentEndEvent flag.

Without clearing that flag, if someone changes the src inside of an ended event callback, m_sentEndEvent remains true even though the source has changed.

Haven't dug into a fix yet but I'm assuming we're not clearing m_sentEndEvent after changing the src.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.