[Webkit-unassigned] [Bug 60518] Expose willStartLiveResize and willEndLiveResize in WebView

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 23 14:38:56 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=60518





--- Comment #18 from Sailesh Agrawal <sail at chromium.org>  2011-05-23 14:38:56 PST ---
(In reply to comment #16)
> (From update of attachment 93519 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=93519&action=review
> 
> Sorry if it comes off as though I'm being nit-picky here.  I just think it is
> important that the API makes sense.
> 
> > Source/WebKit/chromium/public/WebWidget.h:58
> > +    // Called when the user begins to drag the resizer.
> 
> You are still leaving things mysterious for the reader to guess what you mean.
> I think you mean that willStartLiveResize will be followed by a sequence of
> calls to resize(), but you don't say that.  Am I interpreting this API correctly?
> If so, please add a comment to clarify this.

I guess the live resize begin/end messages are meant as hints and can be used to group any sequence of resize events.

I updated the change log to (hopefully) clarify this.

(By the way, thanks for your feedback. Sorry, I've been so slow on updating this patch.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list