[Webkit-unassigned] [Bug 59753] Chromium Mac: Fork ScrollAnimatorMac to ScrollAnimatorChromiumMac for overlay scrollbar support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59753


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94473|review?                     |review+
               Flag|                            |




--- Comment #27 from James Robinson <jamesr at chromium.org>  2011-05-23 13:36:08 PST ---
(From update of attachment 94473)
View in context: https://bugs.webkit.org/attachment.cgi?id=94473&action=review

Seems OK

> Source/WebCore/platform/chromium/ScrollAnimatorChromiumMac.h:55
> +    ScrollAnimatorChromiumMac(ScrollableArea*);

should be explicit

> Source/WebCore/platform/graphics/IntPoint.h:40
> +#if PLATFORM(MAC) || (PLATFORM(CHROMIUM) && OS(DARWIN))

should this just be #if OS(DARWIN)?

> Source/WebCore/platform/graphics/IntPoint.h:122
> +#if (PLATFORM(MAC) || (PLATFORM(CHROMIUM) && OS(DARWIN))) && !defined(NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES)

should this just be #if OS(DARWIN) && !defined(NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES) ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.