[Webkit-unassigned] [Bug 56666] Media Stream API: adding Stream and GeneratedStream classes.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56666





--- Comment #7 from Tony Gentilcore <tonyg at chromium.org>  2011-05-23 06:06:46 PST ---
(From update of attachment 94243)
View in context: https://bugs.webkit.org/attachment.cgi?id=94243&action=review

Just a couple of small questions. Everything else lgtm.

> Source/WebCore/dom/GeneratedStream.cpp:82
> +    if (m_readyState != ENDED)

Since stop() needs to be robust to ENDED streams, perhaps it would be easier to just call stop() unconditionally here at let it fail the first check?

> Source/WebCore/dom/Stream.cpp:57
> +    if (m_readyState == ENDED)

I might be missing it, but it doesn't seem like we'd ever want to call streamEnded while m_readyState == ENDED. If not, should we ASSERT here instead?

> Source/WebCore/dom/Stream.idl:36
> +                 attribute EventListener onreadystatechange;

onreadystatechange isn't in:
http://www.whatwg.org/specs/web-apps/current-work/#stream

Should we have it?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.