[Webkit-unassigned] [Bug 61268] New: REGRESSION (r45620): Node list caches never deleted

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61268

           Summary: REGRESSION (r45620): Node list caches never deleted
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: HTML DOM
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: koivisto at iki.fi


We have

struct NodeListsNodeData {
...
    RefPtr<DynamicNodeList::Caches> m_childNodeListCaches;
...

and

bool NodeListsNodeData::isEmpty() const
{
...
    if (m_childNodeListCaches->refCount())
        return false;
...

The condition is always true and as a result node list caches are never empty and so never destroyed. This is bad for DOM modification performance as maintaing the caches is costly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.