[Webkit-unassigned] [Bug 61262] New: [Refactoring] DocumentMarker should be carried around a pointer, not value.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 22 23:59:25 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=61262

           Summary: [Refactoring] DocumentMarker should be carried around
                    a pointer, not value.
           Product: WebKit
           Version: 525.x (Safari 3.1)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: HTML Editing
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: morrita at google.com
                CC: jpu at apple.com
            Blocks: 61261


Currently DocumentMarker is treat as a value class.
But this has following problems:

- It is wasteful. We are doing unnecessary copying.
- It loose its entity. A living entity of DocumentMarker object is actually a RenderedDocumentMarker, a subclass of DM.
   It would have benefits if we could access it.

Using a DocumentMarker object as a pointer solves these problems.
Concretely, DocumentMarkerController::markersForNode() and markersInRange() should return a vector of pointers.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list