[Webkit-unassigned] [Bug 60167] [Qt] [WebGL] implement Qt WebGL extensions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60167





--- Comment #9 from Benjamin Poulain <benjamin at webkit.org>  2011-05-22 08:23:48 PST ---
(From update of attachment 93121)
View in context: https://bugs.webkit.org/attachment.cgi?id=93121&action=review

> Source/WebCore/platform/graphics/qt/Extensions3DQt.cpp:43
> +    const QString extensions = QLatin1String(reinterpret_cast<const char *>(glGetString(GL_EXTENSIONS)));

glGetString() return 0 in case of error. I would add a test for that. Maybe just an assert if the error condition should never happen.

> Source/WebCore/platform/graphics/qt/Extensions3DQt.cpp:44
> +    m_supportedExtensions = extensions.split(QLatin1String(" "));

QLatin1String->QLatin1Char(' ').

I guess you could set SplitBehavior to be QString::SkipEmptyParts just in case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.