[Webkit-unassigned] [Bug 61236] [chromium] Updating chromium DEPS

Sat May 21 21:40:08 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=61236

Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94318|review?                     |review+
               Flag|                            |

--- Comment #3 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-05-21 21:40:08 PST ---
(From update of attachment 94318)
r=me

but we probably dont want code in the webkit repository to depend on ScopedTempDir.
it would make it very painful if someone ever changed that class in an incompatible 
way.  how would the average chromium hacker know to fixup webkit?  and if they did
know they would then have to deal with the circular dependency.  (hard to roll
webkit w/o things being temporarily broken .)

the contents of webkit_support.h mostly encapsulates the extent of the circular deps 
which we have.  if you dont want to copy code into webkit, then consider exposing 
the "algorithm" of interest as new functions in webkit_support.h.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.