[Webkit-unassigned] [Bug 60897] [Qt] Implement toImageData() in QtWebKit Bridge

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60897


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94090|review?                     |review-
               Flag|                            |




--- Comment #9 from Benjamin Poulain <benjamin at webkit.org>  2011-05-21 14:58:40 PST ---
(From update of attachment 94090)
View in context: https://bugs.webkit.org/attachment.cgi?id=94090&action=review

I was gonna r+, cq-, but I just noticed the doc is missing.
Please update the documentation since this is a public API.

> Source/WebCore/bridge/qt/qt_pixmapruntime.cpp:28
> +#include "JSImageData.h"

We need that one?

> Source/WebKit/qt/tests/hybridPixmap/test.html:23
> +                        myWidget.compare(data[i  ], 0xaa); // R

No space after the i, No need to align the columns in the source.

> Source/WebKit/qt/tests/hybridPixmap/widget.h:48
> +    Q_INVOKABLE QImage abcImage(int format);

Why not put this as a public slot like the others?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.