[Webkit-unassigned] [Bug 31721] Using jQuery to show/hide IMG elements crashes WebKit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 20 19:57:53 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=31721





--- Comment #28 from Andrey Petrov <andrey.petrov at gmail.com>  2011-05-20 19:57:52 PST ---
(From update of attachment 94174)
View in context: https://bugs.webkit.org/attachment.cgi?id=94174&action=review

>> LayoutTests/editing/pasteboard/copy-standalone-image-crash.html:8
>> +     layoutTestController.dumpEditingCallbacks();
> 
> What's the point of dumpEditingCallbacks if you're just going to overwrite it all with PASS in the end?

agreed, this is pretty dumb

>> LayoutTests/editing/pasteboard/copy-standalone-image-crash.html:63
>> +        setTimeout(hideframe, 3000);
> 
> Do we need to use setTimeout?  That makes tests slow and flaky.  Are there some events we should wait for instead?

the bigger 3s timeout is for manual testing. For automation at least one timeout is needed. 
Anyway I reduced amount of timeouts and now with the automation there is only on 10ms timeout.
I hope that is good. The tests executes at 0.4s on my box

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list