[Webkit-unassigned] [Bug 31721] Using jQuery to show/hide IMG elements crashes WebKit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31721


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94174|commit-queue?               |commit-queue-
               Flag|                            |




--- Comment #26 from Adam Barth <abarth at webkit.org>  2011-05-20 11:13:19 PST ---
(From update of attachment 94174)
View in context: https://bugs.webkit.org/attachment.cgi?id=94174&action=review

> LayoutTests/editing/pasteboard/copy-standalone-image-crash.html:8
> +     layoutTestController.dumpEditingCallbacks();

What's the point of dumpEditingCallbacks if you're just going to overwrite it all with PASS in the end?

> LayoutTests/editing/pasteboard/copy-standalone-image-crash.html:63
> +        setTimeout(doctxmenu, 10);
> +        setTimeout(hideframe, 3000);

Do we need to use setTimeout?  That makes tests slow and flaky.  Are there some events we should wait for instead?

> LayoutTests/editing/pasteboard/copy-standalone-image-crash.html:65
> +        layoutTestController.waitUntilDone();

This should be in the if-block at the top of the page.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.