[Webkit-unassigned] [Bug 60184] Introduce HTML5 track list objects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60184





--- Comment #11 from Leandro Graciá Gil <leandrogracia at chromium.org>  2011-05-20 04:40:33 PST ---
(From update of attachment 94076)
View in context: https://bugs.webkit.org/attachment.cgi?id=94076&action=review

>> Source/WebCore/dom/ExclusiveTrackList.cpp:62
>> +    ASSERT(index >= NoSelection && index < static_cast<long>(length()));
> 
> Doesn't the checkIndex() test above mean that this ASSERT can never fire?

Fixed. Assert removed.

>> Source/WebCore/dom/MultipleTrackList.cpp:67
>> +    ASSERT(index < length());
> 
> Ditto.

Fixed.

>> Source/WebCore/dom/MultipleTrackList.cpp:78
>> +    ASSERT(index < length());
> 
> Ditto.

Fixed.

>> Source/WebCore/dom/TrackList.cpp:78
>> +}
> 
> The spec says "If there is no such track, then the method must instead throw an INDEX_SIZE_ERR exception", so shouldn't this also fail if index is negative?

The index in this case is unsigned, but I'm fixing this since the ExclusiveTrackList objects will provide signed indexes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.