[Webkit-unassigned] [Bug 56200] [GTK] WebKitIconDatabase doesn't keep icons cached

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56200





--- Comment #30 from Xan Lopez <xan.lopez at gmail.com>  2011-05-20 03:12:08 PST ---
(From update of attachment 92245)
View in context: https://bugs.webkit.org/attachment.cgi?id=92245&action=review

All the Since: should be 1.5.1, I agree we have to deprecate the old signal, we cannot just remove it. Also, as I say, it's not clear to me that we should not provide some easy way for apps to just say "I want persistent icons, store them here <path>"; the stuff that we require every app to do seems like the default behavior that most of them will want to enable anyway.

> Source/WebKit/gtk/WebCoreSupport/IconDatabaseClientGtk.cpp:23
> + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

We use LGPL2+ for the stuff we write unless we have a good reason not to, AFAIK.

> Source/WebKit/gtk/webkit/webkiticondatabase.cpp:212
> +     * this signal.

Why would I ever want to know about only the URI? Can't the data signal just carry the URI too?

> Source/WebKit/gtk/webkit/webkiticondatabase.cpp:227
> +     * WebKitIconDatabase::icon-uri-imported:

Should be icon-data-imported

> Source/WebKit/gtk/webkit/webkiticondatabase.cpp:492
> + * webkit_icon_database_database_cleanup:

Missing 'delay'

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.