[Webkit-unassigned] [Bug 61098] Web Inspector: Provide inspector extension API to access timeline data

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61098





--- Comment #12 from Andrey Kosyakov <caseq at chromium.org>  2011-05-20 02:01:22 PST ---
(In reply to comment #9)
> There are open questions:
> - What is a good way to copy the record, is there a utility? I use JSON.parse(JSON.stringify(record)) currently

Either this way, or create a new object that has __proto__ set to the original object, e.g.

record.data = { __proto__: record.data }

I have no idea which one is actually faster (using prototypes may have some performance impact as well). As long as we only do this for certain record types, especially those that a rare (e.g. network), the performance impact may be negligible.

> - When adding a listener, the actual start of the instrumentation could be delayed. Do we have to add a callback to EventSink.addListener which is called as soon as the subscription is successful (seems strange, in this case I would rather have a explicit start/stop again)? Or can we neglect that? 

I'd rather neglect this, unless you, as the API client, happen to have a specific use case for this.

> If the async requests wont be executed out-of-order, this is probably not an issue.

We do expect that sequential calls from the same client are received by the server in the same sequence, and the callbacks on the client are invoked in the same order that server invokes them. This seems to be guaranteed by the transport we use (MessagePort has to use a single event queue, as per DOM messaging spec).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.