[Webkit-unassigned] [Bug 61098] Web Inspector: Provide inspector extension API to access timeline data

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61098





--- Comment #10 from Andrey Kosyakov <caseq at chromium.org>  2011-05-20 01:03:14 PST ---
(From update of attachment 94123)
View in context: https://bugs.webkit.org/attachment.cgi?id=94123&action=review

> Source/WebCore/inspector/front-end/TimelinePanel.js:281
> +        this.toggleTimelineButton.toggled != this.toggleTimelineButton.toggled;

Does this work? != is a boolean operator, not an assignment.

> Source/WebCore/inspector/front-end/TimelinePanel.js:299
> +        if (this.toggleTimelineButton.toggled) {

Nit: WebKit style implies that we skip block parenthesis {} in case there's just one statement under the conditional/loop operator.

> LayoutTests/inspector/extensions/extensions-events.html:109
> +        if (record.type == "Layout") {

Nit: ===

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.