[Webkit-unassigned] [Bug 61131] [V8] Explicitly mark objects with complex GC rules.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61131





--- Comment #5 from anton muhin <antonm at chromium.org>  2011-05-20 01:00:49 PST ---
(From update of attachment 94084)
View in context: https://bugs.webkit.org/attachment.cgi?id=94084&action=review

LGTM!  Very nice

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:239
> +            next if ($parent eq "EventTarget");

nit: I am not sure we put condition into parents in this file, I think preferred style is next if $parent eq "EventTarget"

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:291
> +            next if ($parent eq "EventTarget");

ditto nitto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.