[Webkit-unassigned] [Bug 60869] Convert json_results_generator.py to output version 4 JSON.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 19 22:15:39 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=60869


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94170|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #8 from Ojan Vafai <ojan at chromium.org>  2011-05-19 22:15:39 PST ---
(From update of attachment 94170)
View in context: https://bugs.webkit.org/attachment.cgi?id=94170&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:297
> +            _log.info(builder_name + " not in " + str(results_json))

Sorry, I didn't notice this before, but do we really want to log here? I prefer avoiding spewing too much to the log since this is always run when people run the tests. If you really think this is worthwhile, it should be _log.debug so it's only logged with --verbose.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list