[Webkit-unassigned] [Bug 60827] [GTK] Implement GraphicsContextCairo::imageInterpolationQuality().

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60827





--- Comment #4 from Ryuan Choi <ryuan.choi at samsung.com>  2011-05-19 21:59:42 PST ---
(In reply to comment #2)
> (From update of attachment 93601 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=93601&action=review
> 
> Nice! I have a few comments below. In general, I think this patch needs a bit more context either in the ChangeLog or in the bug report. Are you just filling out a stub here?
> 
> > Source/WebCore/ChangeLog:8
> > +        Implement GraphicsContextCairo::imageInterpolationQuality.
> 
> Might make sense to describe how this affects drawing performance or give more information about what prompted this change.
> 
> > Source/WebCore/ChangeLog:16
> > +        * platform/graphics/cairo/GraphicsContextCairo.cpp:
> > +        (WebCore::GraphicsContext::setImageInterpolationQuality):
> > +        (WebCore::GraphicsContext::imageInterpolationQuality):
> > +        * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
> > +        * platform/graphics/cairo/PlatformContextCairo.cpp:
> > +        (WebCore::PlatformContextCairo::drawSurfaceToContext):
> > +
> 
> Please fill these out.
> 
> > Source/WebCore/platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:105
> > +    InterpolationQuality imageInterpolationQuality;
> 
> It makes more sense to have this as a member of PlatformContextCairo, don't you think?

Thank you for your review.
I prepared patch like you mentioned.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.