[Webkit-unassigned] [Bug 61088] run-api-tests should run one test per process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61088





--- Comment #8 from Dmitry Lomov <dslomov at google.com>  2011-05-19 14:29:10 PST ---
(From update of attachment 94115)
View in context: https://bugs.webkit.org/attachment.cgi?id=94115&action=review

>> Tools/Scripts/run-api-tests:39
>> +use Term::ANSIColor qw(:constants);
> 
> Is this part of the standard Perl distribution?  From briefly googling, I came across <http://perldoc.perl.org/perlfaq8.html#How-do-I-do-fancy-stuff-with-the-keyboard%2fscreen%2fmouse%3f>, which states that it isn't. That being said, Mac OS 10 10.6.7 includes this Perl module. We should also look to see if the WebKit Cgywin distribution (for WebKit Windows development) downloads and installs this module. I take it from Adam Roben's review that this module is included in our Cgywin distribution. Even better, can we make this module optional since it only affects the visual appearance of the output?

This has been there in original run-api-tests. This works on mac and and cygwin. I can remove this dependency, but maybe not in this checkin?

>> Tools/Scripts/run-api-tests:45
>> +sub populateTests();
> 
> Nit: Can we sort these?

Again, comes from original run-api-tests, but good call - I'll sort.

>> Tools/Scripts/run-api-tests:86
>> +}
> 
> I would write this in one-line:
> 
> exit(runAllTests() > 0);

Hmm, my tiny brain has a hard time reasoning about integer->boolean->integer conversions...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.