[Webkit-unassigned] [Bug 61088] run-api-tests should run one test per process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61088


Adam Roben (:aroben) <aroben at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93974|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #4 from Adam Roben (:aroben) <aroben at apple.com>  2011-05-19 13:57:21 PST ---
(From update of attachment 93974)
View in context: https://bugs.webkit.org/attachment.cgi?id=93974&action=review

> Tools/ChangeLog:8
> +2011-05-18  Dmitry Lomov  <dslomov at google.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        run-api-tests should run one test per process
> +        https://bugs.webkit.org/show_bug.cgi?id=61088
> +
> +        * Scripts/run-api-tests:

It would be good to have some more comments in here explaining where this code came from. I assume a lot of it is from an older version of run-api-tests.

> Tools/Scripts/run-api-tests:86
> +if (runAllTests()) {
> +    exit 1;
> +}
> +else {
> +    exit 0;
> +}

"else" should be on the same line as "}". But there's no need for "else" after "exit".

> Tools/Scripts/run-api-tests:181
> +    f ($result == 0) {

"f"?

We normally say "!$result" instead of "$result == 0".

> Tools/Scripts/run-api-tests:207
> +        unless ($verbose) {
> +            open(DEVNULL, ">", File::Spec->devnull()) or die "Failed to open /dev/null";
> +            $childErr = ">&DEVNULL";
> +        } else {
> +            $childErr = ">&STDERR";
> +        }

I find "unless/else" confusing. "if/else" hurts my tiny head much less.

> Tools/Scripts/run-api-tests:297
> -
> +    

You should undo this change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.