[Webkit-unassigned] [Bug 60377] [Qt] fast/canvas/webgl/gl-uniform-arrays.html failing for Qt on Linux

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60377





--- Comment #21 from Idrees <sidreesshah at hotmail.com>  2011-05-19 10:11:11 PST ---
(In reply to comment #19)
> (From update of attachment 93952 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=93952&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        [Qt] fast/canvas/webgl/gl-uniform-arrays.html failing for Qt on Linux
> > +        https://bugs.webkit.org/show_bug.cgi?id=60377 
> > +
> > +        LayoutTests/fast/canvas/webgl/gl-uniform-arrays.html
> 
> It would be nice to have a description of what was causing the problem and how this patch solves it.


The problem was that we were truncating the name of the active uniform array without checking if it contains the array braces "[0]". As a result we were truncating the actual name of the active uniform. My patch checks for the array braces before taking them out.

Also we do not need assert in useProgram as program can be null. 

I have added these comments to the changelog as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.