[Webkit-unassigned] [Bug 60184] Introduce HTML5 track list objects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60184





--- Comment #8 from Leandro Graciá Gil <leandrogracia at chromium.org>  2011-05-19 08:53:19 PST ---
(From update of attachment 93773)
View in context: https://bugs.webkit.org/attachment.cgi?id=93773&action=review

>> Source/WebCore/dom/ExclusiveTrackList.cpp:76
>> +}
> 
> Shouldn't the track be selected synchronously (in select) and only the 'change' event posted asynchronously? The spec only says that the event should happen in the task:
> 
>   The select(index) must select the track with index index,
>   if there is one, unselecting whichever track was previously
>   selected. If there is no track with index index, it must 
>   instead throw an INDEX_SIZE_ERR exception.
> 
>   Whenever the selected track is changed, the user agent 
>   must queue a task to fire a simple event named change 
>   at the MultipleTrackList object.
> 
> http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#dom-tracklist-select
> 
> Also, is there any reason to not use dispatchChangeEvent() in the base class?

Fixed the problem with the asynchronous selection. The index is properly checked and raising the appropriate exceptions in the checkIndex method. Now using the postChangeEvent method from the parent class as it should have done from the start.

>> Source/WebCore/dom/ExclusiveTrackList.idl:32
>> +        // A bug has been already submitted to the spec draft.
> 
> It would be good to include the bug url here.

Fixed.

>> Source/WebCore/dom/MultipleTrackList.cpp:81
>> +}
> 
> Ditto the question about select() above.

Fixed.

>> Source/WebCore/dom/MultipleTrackList.cpp:102
>> +}
> 
> And here.

Fixed.

>> Source/WebCore/dom/TrackList.cpp:136
>> +}
> 
> Bug number?

Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.