[Webkit-unassigned] [Bug 55455] [EFL] HTML saving feature

Thu May 19 07:46:07 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=55455

Leandro Pereira <leandro at profusion.mobi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93880|review?                     |review-
               Flag|                            |

--- Comment #20 from Leandro Pereira <leandro at profusion.mobi>  2011-05-19 07:46:06 PST ---
(From update of attachment 93880)
View in context: https://bugs.webkit.org/attachment.cgi?id=93880&action=review

> Source/WebKit/efl/ewk/ewk_frame.cpp:2040
> +    // Look for <html> tag. If it exists, the node contatins all document's source.

What will happen if it is a XHTML page? WAP page?

> Source/WebKit/efl/ewk/ewk_frame.cpp:2062
> +    *frame_source = static_cast<char*>(malloc(sizeof(char) * source_length + sizeof(char)));

sizeof(char) = 1 :)

> Source/WebKit/efl/ewk/ewk_frame.cpp:2116
> +        if (eina_error_get()) {

eina_error_get() does not catches the possible failure in allocation due to strdup() returning NULL, only eina-related stuff, like allocating a new node for the list.

The error handling is fine, however; change just the error detection.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.