[Webkit-unassigned] [Bug 61098] Web Inspector: Provide inspector extension API to access timeline data

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 19 06:54:28 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=61098





--- Comment #8 from Andrey Kosyakov <caseq at chromium.org>  2011-05-19 06:54:27 PST ---
(From update of attachment 94008)
View in context: https://bugs.webkit.org/attachment.cgi?id=94008&action=review

> Source/WebCore/inspector/front-end/TimelineManager.js:48
> +        if (this._enablementCount == 1)

We normally use === instead of == where possible.

> Source/WebCore/inspector/front-end/TimelineManager.js:54
> +        if (this._enablementCount == 0) {

We normally put this as !this._enablementCount (or at least use ===)

> Source/WebCore/inspector/front-end/TimelineManager.js:59
> +        if (this._enablementCount == 0)

ditto.

> Source/WebCore/inspector/front-end/TimelinePanel.js:303
>          if (record.type == WebInspector.TimelineAgent.RecordType.ResourceSendRequest) {

===

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list