[Webkit-unassigned] [Bug 61098] Web Inspector: Provide inspector extension API to access timeline data

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61098





--- Comment #5 from Andrey Kosyakov <caseq at chromium.org>  2011-05-19 04:55:14 PST ---
(From update of attachment 94008)
View in context: https://bugs.webkit.org/attachment.cgi?id=94008&action=review

> Source/WebCore/inspector/front-end/ExtensionAPI.js:385
> +    this.onStopped = new EventSink("timeline-stopped");

Why do we need onStarted/onStopped? Looks like start/stop will only be triggered upon client actions (i.e. subscription, unsubscription), so we don't seem to need another notification that timeline has actually started/stopped.

> Source/WebCore/inspector/front-end/TimelinePanel.js:281
> +        this.toggleTimelineButton.toggled ^= true;

this.toggleTimelineButton.toggled = !this.toggleTimelineButton.toggled;
We don't use bit-wise ^ on booleans normally. This works, but will change type from Boolean to Number, which looks a bit strange.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.