[Webkit-unassigned] [Bug 60752] Selector matching doesn't update when DOM changes ("[data-a=x] #x")

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60752





--- Comment #6 from Dominic Cooney <dominicc at chromium.org>  2011-05-18 22:25:34 PST ---
(From update of attachment 94026)
View in context: https://bugs.webkit.org/attachment.cgi?id=94026&action=review

> LayoutTests/fast/css/attribute-selector-dynamic-no-elementstyle-expected.txt:3
> +This test checks whether CSS attribute selectors are re-evaluated after attribute changes in html elements which are having no style associated with them.

html elements -> elements (this isn’t HTML-specific, right?)

are having -> have

> Source/WebCore/ChangeLog:8
> +        Currently CSSStyleSelector maintains a HashSet of attributes (m_selectorAttrs)

Is it worth beefing up the test coverage for these specific cases?

> Source/WebCore/ChangeLog:27
> +        simply looked up in this pre-papulated hash set.

populated

> Source/WebCore/css/CSSStyleSelector.cpp:2379
>          // FIXME: Handle the case were elementStyle is 0.

Is this FIXME still valid?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.