[Webkit-unassigned] [Bug 60950] Port the SmallStrings cache to Weak<T>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60950





--- Comment #4 from Xan Lopez <xan.lopez at gmail.com>  2011-05-18 14:01:06 PST ---
Created an attachment (id=93980)
 --> (https://bugs.webkit.org/attachment.cgi?id=93980&action=review)
weakptrsmallstrings.diff

Here's the WIP patch.

As I said this makes ~40 tests crash, so I'm sure I'm doing something wrong. I guess either the way I use the weak pointers, or the way I unpack the JSString from them, or both. Comments welcome.

BTW, I had to change the string cache to be a pointer type in the global data, otherwise there was a circular dependency when trying to use Weak in SmallStrings.h. (JSGlobalData.h -> SmallStrings.h -> Weak.h -> JSGlobalData.h)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.