[Webkit-unassigned] [Bug 60377] [Qt] fast/canvas/webgl/gl-uniform-arrays.html failing for Qt on Linux

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60377


Idrees <sidreesshah at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[WK2][Qt]                   |[Qt]
                   |fast/canvas/webgl/gl-unifor |fast/canvas/webgl/gl-unifor
                   |m-arrays.html failing for   |m-arrays.html failing for
                   |Qt on Linux                 |Qt on Linux




--- Comment #14 from Idrees <sidreesshah at hotmail.com>  2011-05-18 11:15:14 PST ---
(In reply to comment #11)
> (From update of attachment 93807 [details])
> You need to describe the change in the changelog, like why the assertion is not needed.

Ok i will do so.

> 
> Also, without changelog, it looks like you are fixing 2 unrelated things:

Both are related to same test case. Thats why i created a single patch for it. Also both are one liners. so in my view creating a single patch makes sense.

> -The assert which is Qt specific

agreed.

> -The uniform name, which is common code.

agreed. I have not checked it with other platforms but i have mentioned the possibility that it might be reproducible on other platforms. I was just checking it on qt webkit2.

> 
> I would prefer 2 patches with the test for each change.
> 
> Finally, how is this related to WebKit 2? Your changes only WebCore common code?

I had only tested with Webkit2 for Qt. Now i tested with qt webkit and got the same behaviour. so will remove wk2 from the summary.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.