[Webkit-unassigned] [Bug 57543] -webkit-visual-word does not work on words separated by multiple spaces

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 18 10:26:19 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=57543





--- Comment #26 from Xiaomei Ji <xji at chromium.org>  2011-05-18 10:26:19 PST ---
(In reply to comment #25)
> (From update of attachment 93839 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=93839&action=review
> 
> > Source/WebCore/editing/visible_units.cpp:-1341
> > +    bool isLastWordBreakInBox = false;
> >      while (1) {
> > -        bool isLastWordBreakInBox = false;
> 
> Is this change necessary after you've removed the change in nextWordBreakInBoxInsideBlockWithDifferentDirectionality?

It is not necessary for functionality correctness (isLastWordBreakInBox is always assigned in the callee), but it is good performance wise, so, I kept it there.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list