[Webkit-unassigned] [Bug 61070] Web Inspector: support for emulating element's pseudo class state in styleRulesForElement()

Wed May 18 09:59:08 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=61070

Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93928|review+                     |review-
               Flag|                            |

--- Comment #2 from Pavel Feldman <pfeldman at chromium.org>  2011-05-18 09:59:08 PST ---
(From update of attachment 93928)
View in context: https://bugs.webkit.org/attachment.cgi?id=93928&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

Should be no OOPS here. I'll point you to the inspector tests offline so that it was covered.

> Source/WebCore/css/CSSStyleSelector.cpp:1994
> +PassRefPtr<CSSRuleList> CSSStyleSelector::styleRulesForElement(Element* e, bool authorOnly, bool includeEmptyRules, CSSRuleFilter filter, unsigned emulateElementPseudoClass)

emulatePseudoClassMask ?

> Source/WebCore/css/CSSStyleSelector.cpp:2803
> +                if (emulateElementPseudoClass != EmulateNone)

I'd suggest

if (emulatePseudoClassMask & EmulateFocus)
    return true;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.