[Webkit-unassigned] [Bug 60377] [WK2][Qt] fast/canvas/webgl/gl-uniform-arrays.html failing for Qt on Linux

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 18 07:18:24 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=60377


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93807|review?                     |review-
               Flag|                            |




--- Comment #11 from Benjamin Poulain <benjamin at webkit.org>  2011-05-18 07:18:24 PST ---
(From update of attachment 93807)
You need to describe the change in the changelog, like why the assertion is not needed.

Also, without changelog, it looks like you are fixing 2 unrelated things:
-The assert which is Qt specific
-The uniform name, which is common code.

I would prefer 2 patches with the test for each change.

Finally, how is this related to WebKit 2? Your changes only WebCore common code?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list