[Webkit-unassigned] [Bug 60897] Implement toImageData() in QtWebKit Bridge

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 18 04:16:23 PDT 2011


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
  Attachment #93660|review?                     |review-
               Flag|                            |

--- Comment #4 from Benjamin Poulain <benjamin at webkit.org>  2011-05-18 04:16:23 PST ---
(From update of attachment 93660)
View in context: https://bugs.webkit.org/attachment.cgi?id=93660&action=review

> Source/WebCore/bridge/qt/qt_pixmapruntime.cpp:100
> +    void copyPixels(QImage image, int width, int height, unsigned char* destPixels)

This code looks very inefective.

What about using QImage::convertToFormat() to always convert to QImage::Format_ARGB32, and then do the byte shifting? Qt already has optimized color conversions fonctions for plenty of formats.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list