[Webkit-unassigned] [Bug 61023] [Chromium] IME candidate window appears wrong position in an iframe

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61023





--- Comment #10 from Kenichi Ishibashi <bashi at chromium.org>  2011-05-17 23:27:16 PST ---
(From update of attachment 93871)
View in context: https://bugs.webkit.org/attachment.cgi?id=93871&action=review

Kent-san,

Thank you for review.  I'd like to ask for original author's comments.  Then, I'll revise the patch.

>> LayoutTests/platform/chromium-mac/editing/input/ime-candidate-window-position-expected.txt:7
>> +PASS rect[1] is frame.offsetTop + input.offsetTop
> 
> The output order looks very broken.
> You should use jsTestIsAsync&finishJSTest().  See http://trac.webkit.org/browser/trunk/LayoutTests/http/tests/websocket/tests/close-event.html?rev=86315

Thank you for letting me know that.  I'll use these functions.

>> LayoutTests/platform/chromium-mac/editing/input/ime-candidate-window-position.html:19
>> +        rect = textInputController.firstRectForCharacterRange(0, 0);
> 
> The first line looks unneecssary.

I'll remove it.

>> Source/WebKit/chromium/src/WebFrameImpl.cpp:1164
>> +    rect = frame()->view()->contentsToWindow(rect);
> 
> Is firstRectForCharacterRange() used only for DRT and IME? Won't his change make regressions for other usages?

Actually, I'm not sure this change won't make regressions so I'd like to ask original author and reviewers of their advices and suggestions.  If my understand correct, WebFrameImpl::firstRectForCharacterRange() is an implementation of Cocoa's NSTextInputClient protocol.  I think it could be called other components.  I looked for why the original code excludes editable elements for adjusting, but couldn't find the reason.  As far as I investigated,  we need to adjust coordinates including editable elements to place the candidate window on the right position.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.