[Webkit-unassigned] [Bug 61023] [Chromium] IME candidate window appears wrong position in an iframe

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61023


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93871|review?                     |review-
               Flag|                            |




--- Comment #8 from Kent Tamura <tkent at chromium.org>  2011-05-17 23:06:27 PST ---
(From update of attachment 93871)
View in context: https://bugs.webkit.org/attachment.cgi?id=93871&action=review

Chromium bots runs all of tests even in LayoutTests/platform/.  You need to update test_expectations.txt.

> LayoutTests/platform/chromium-mac/editing/input/ime-candidate-window-position-expected.txt:7
> +PASS successfullyParsed is true
> +
> +TEST COMPLETE
> +rect[0] denotes x coodinate and rect[1] denotes y coodinate
> +PASS rect[0] is frame.offsetLeft + input.offsetLeft + 1
> +PASS rect[1] is frame.offsetTop + input.offsetTop

The output order looks very broken.
You should use jsTestIsAsync&finishJSTest().  See http://trac.webkit.org/browser/trunk/LayoutTests/http/tests/websocket/tests/close-event.html?rev=86315

> LayoutTests/platform/chromium-mac/editing/input/ime-candidate-window-position.html:19
> +        textInputController.firstRectForCharacterRange(0, 0);
> +        rect = textInputController.firstRectForCharacterRange(0, 0);

The first line looks unneecssary.

> Source/WebKit/chromium/src/WebFrameImpl.cpp:1164
> -    // When inside an text control, don't adjust the range.
> -    if (!selectionRoot)
> -        rect = frame()->view()->contentsToWindow(rect);
> +    rect = frame()->view()->contentsToWindow(rect);

Is firstRectForCharacterRange() used only for DRT and IME? Won't his change make regressions for other usages?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.