[Webkit-unassigned] [Bug 55728] [fileapi] Worker File API calls that create Blobs fail in debug builds due to random number generator thread assertion

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55728


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dslomov at google.com




--- Comment #41 from David Levin <levin at chromium.org>  2011-05-17 16:09:09 PST ---
(In reply to comment #40)
> 
> Looks like s_dtoaP5Mutex is NULL because it's not initialized here in JavaScriptCore/runtime/InitializeThreading.cpp.
> That file is not built into chromium.
> 
> static void initializeThreadingOnce()
> {
>     // StringImpl::empty() does not construct its static string in a threadsafe fashion,
>     // so ensure it has been initialized from here.
>     StringImpl::empty();
> 
>     WTF::initializeThreading();
>     wtfThreadData();
>     JSGlobalData::storeVPtrs();
> #if ENABLE(JSC_MULTIPLE_THREADS)
>     s_dtoaP5Mutex = new Mutex;
>     initializeDates();
>     RegisterFile::initializeThreading();
> #endif
> }


Good point. 

Both 
    s_dtoaP5Mutex = new Mutex;
    initializeDates();
are in the wrong place.

Seems like 
     // StringImpl::empty() does not construct its static string in a threadsafe fashion,
     // so ensure it has been initialized from here.
     StringImpl::empty();
     wtfThreadData();
Should also be done in wtf.

btw, the asserts are about to be removed from this method: https://bugs.webkit.org/show_bug.cgi?id=60846 so this issue won't be noticed.

The real issue here (imo) is getting WTF_MULTIPLE_THREADS turned on for chromium but the current fire is won't be there shortly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.