[Webkit-unassigned] [Bug 60569] Add flags to Chromium ImageDiff to write image comparison metrics out to files.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60569





--- Comment #8 from Tony Chang <tony at chromium.org>  2011-05-17 10:08:43 PST ---
(From update of attachment 93760)
View in context: https://bugs.webkit.org/attachment.cgi?id=93760&action=review

This change LGTM.  Did you want this patch reviewed?  If so, please set r? and set cq? if you want someone to commit it for you.

> Tools/DumpRenderTree/chromium/ImageDiff.cpp:228
> +    for (int y = 0; y < h; y++) {
> +        for (int x = 0; x < w; x++) {

Nit: WebKit style prefers ++y and ++x

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.