[Webkit-unassigned] [Bug 58730] currentColor not supported in CSS gradients

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 16 22:37:15 PDT 2011


--- Comment #5 from David Barr <davidbarr at chromium.org>  2011-05-16 22:37:15 PST ---
(From update of attachment 93714)
View in context: https://bugs.webkit.org/attachment.cgi?id=93714&action=review

>> Source/WebCore/css/CSSGradientValue.cpp:159
>> +            stops[i].color = renderer->document()->styleSelector()->getColorFromPrimitiveValue(color);
> I still don't get this part. getColorFromPrimitiveValue() handles currentCOlor already.

In this context, CSSStyleSelector::m_style is NULL rather than equal to the local var 'style'.
This change works around that issue pending a change in the path to getColorFromPrimitiveValue().
Maybe a FIXME is warranted? This feature addition exposes a lurking NULL-deref bug.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list