[Webkit-unassigned] [Bug 60871] HTML5 Number Spinbox displays a 0 in situations where a 0 is not between the min and max.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60871


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93724|review?                     |review+, commit-queue+
               Flag|                            |




--- Comment #13 from Kent Tamura <tkent at chromium.org>  2011-05-16 18:50:43 PST ---
(From update of attachment 93724)
View in context: https://bugs.webkit.org/attachment.cgi?id=93724&action=review

> LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js:245
> +shouldBe('stepUpExplicitBounds(-4, 4, 1, "")', '"1"');
> +shouldBe('stepDownExplicitBounds(-4, 4, 1, "")', '"-1"');
> +shouldBe('stepDownExplicitBounds(0, 4, 1, "")', '"0"');
> +shouldBe('stepUpExplicitBounds(-4, 0, 1, "")', '"0"');
> +shouldBe('stepDownExplicitBounds(1, 4, 1, "")', '"1"');
> +shouldBe('stepUpExplicitBounds(1, 4, 1, "")', '"1"');
> +shouldBe('stepDownExplicitBounds(-4, -1, 1, "")', '"-1"');
> +shouldBe('stepUpExplicitBounds(-4, -1, 1, "")', '"-1"');
> +shouldBe('stepUpExplicitBounds(-100, null, 3, "")', '"2"');
> +shouldBe('stepDownExplicitBounds(-100, null, 3, "")', '"-1"');
> +shouldBe('stepUpExplicitBounds(1, 4, 1, 0)', '"1"');
> +shouldBe('stepDownExplicitBounds(1, 4, 1, 0)', '"0"');
> +shouldBe('stepDownExplicitBounds(-4, -1, 1, 0)', '"-1"');
> +shouldBe('stepUpExplicitBounds(-4, -1, 1, 0)', '"0"');
> +shouldBe('stepUpExplicitBounds(-100, null, 3, 3)', '"5"');
> +shouldBe('stepDownExplicitBounds(-100, null, 3, 3)', '"2"');

nit: The function arguments should be strings unless null.
Specifying numbers causes extra conversion.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.