[Webkit-unassigned] [Bug 60871] HTML5 Number Spinbox displays a 0 in situations where a 0 is not between the min and max.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60871





--- Comment #10 from Kent Tamura <tkent at chromium.org>  2011-05-16 17:58:47 PST ---
(In reply to comment #9)
> > Instead of this change, we had better do currentStringValue=value() just after setValueAsNumber().
> > Anyway, this also fixes another bug http://crbug.com/76046 , right?
> I didn't know the bug. But fortunately, the bug is gone after the change.
> 
> My original intention is to fix this one
> //   * If 0 is in-range, but not matched to step value
> //     - The value should be the larger matched value nearest to 0 if n > 0   //       e.g. <input type=number min=-100 step=3> -> 2               
> 
> Should I separate the bug entry?

I don't think so.  This change is needed for this issue.  Let's go ahead with the single patch.

> Also I suppose 
> > > +        if (stepMismatch(value())) {
> Is better than currentStringValue=value().
> 
> Because after this step, the following steps are executed,
> if (currentStringValue != value()) {
>     if (m_inputType->isRangeControl())
>             dispatchFormControlChangeEvent();
>         else
>             dispatchFormControlInputEvent();
> }
> 
> So shouldn't we change currentStringValue, right?

Ah, you're right.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.