[Webkit-unassigned] [Bug 60682] Add DynamicsCompressorNode implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60682


Stephen White <senorblanco at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93528|review?                     |review+
               Flag|                            |




--- Comment #9 from Stephen White <senorblanco at chromium.org>  2011-05-16 12:32:02 PST ---
(From update of attachment 93528)
View in context: https://bugs.webkit.org/attachment.cgi?id=93528&action=review

Looks good.  r=me

> Source/WebCore/platform/audio/DynamicsCompressorKernel.cpp:298
> +                double dbPerFrame = attenuationDb / satReleaseFrames;

Perf nit:  This division could still be hoisted out of the loop (just a side note, totally up to you if it's necessary).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.