[Webkit-unassigned] [Bug 60827] [GTK] Implement GraphicsContextCairo::imageInterpolationQuality().

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60827


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93601|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2011-05-16 12:27:03 PST ---
(From update of attachment 93601)
View in context: https://bugs.webkit.org/attachment.cgi?id=93601&action=review

Nice! I have a few comments below. In general, I think this patch needs a bit more context either in the ChangeLog or in the bug report. Are you just filling out a stub here?

> Source/WebCore/ChangeLog:8
> +        Implement GraphicsContextCairo::imageInterpolationQuality.

Might make sense to describe how this affects drawing performance or give more information about what prompted this change.

> Source/WebCore/ChangeLog:16
> +        * platform/graphics/cairo/GraphicsContextCairo.cpp:
> +        (WebCore::GraphicsContext::setImageInterpolationQuality):
> +        (WebCore::GraphicsContext::imageInterpolationQuality):
> +        * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
> +        * platform/graphics/cairo/PlatformContextCairo.cpp:
> +        (WebCore::PlatformContextCairo::drawSurfaceToContext):
> +

Please fill these out.

> Source/WebCore/platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:105
> +    InterpolationQuality imageInterpolationQuality;

It makes more sense to have this as a member of PlatformContextCairo, don't you think?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.