[Webkit-unassigned] [Bug 60743] Replace docTop/Right/Bottom/Left/Width/Height with documentRect

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60743





--- Comment #3 from Eric Seidel <eric at webkit.org>  2011-05-16 11:05:37 PST ---
(From update of attachment 93392)
View in context: https://bugs.webkit.org/attachment.cgi?id=93392&action=review

Fantastic!

> Source/WebCore/page/FrameView.cpp:491
> +    ScrollView::setScrollOrigin(IntPoint(-rect.x(), -rect.y()), !m_frame->document()->printing(), size == contentsSize());

Is there a helper for producing -x, -y from x, y?  What about just IntSize() - rect.location()?  I'm not sure that's more clear though, so that may be a bad idea.... just brainstorming. :)

> Source/WebCore/rendering/RenderLayerCompositor.cpp:1143
> +        m_rootPlatformLayer->setSize(FloatSize(documentRect.size()));

Do you need the explicit FloatSize conversion here?  I doubt it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.