[Webkit-unassigned] [Bug 58652] Web Inspector: Background network events collection - add GUI to Inspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58652





--- Comment #30 from Sergey Vorobyev <sergeyvorobyev at google.com>  2011-05-16 09:36:59 PST ---
(From update of attachment 93638)
View in context: https://bugs.webkit.org/attachment.cgi?id=93638&action=review

>> LayoutTests/http/tests/inspector/network-test.js:5
>> +    if (!WebInspector.panels.network._backgroundCollectionEnabled) {
> 
> No need { }

done

>> LayoutTests/http/tests/inspector/network-test.js:21
>> +    //resources.sort(function(a, b) {return a.url.localeCompare(b.url);});
> 
> Please do not land commented code.

Oh, thanks for this point. In fact commented code is coorect and resources.sort() was just experement

>> LayoutTests/http/tests/inspector/network-test.js:24
>> +    for (i = 0; i < resources.length; i++) {
> 
> No need for { }

done.

>> LayoutTests/http/tests/inspector/network/network-clear-after-disabled.html:32
>> +        InspectorTest.evaluateInPage("frontendReopeningCount", function(result) {
> 
> Please do not use anonymous functions.

ok, done. But I just take this pattern from inspector/debugger/open-close-open.html test.

>> LayoutTests/http/tests/inspector/network/network-clear-after-disabled.html:33
>> +            if (result._description === "0") {
> 
> What is _description ?

Again, I take it from inspector/debugger/open-close-open.htm
I tried make same thing another way, but didn't invent how...
Actually I don't know, how I can get evaluating value, except _description

>> LayoutTests/http/tests/inspector/network/network-close-load-open.html:24
>> +    if (loadedResourceCount === 2) {
> 
> No need for {}

done. But is code style strict for LayoutTests? I mean same { } in http/tests/inspector/network/network-size.html
And Tools/Scripts/check-webkit-style doesn't produce warning on this code...

>> LayoutTests/http/tests/inspector/network/network-open-load-reopen.html:23
>> +    if (++loadedResourceCount === 2) {
> 
> {}

done

>> Source/WebCore/inspector/Inspector.json:455
>> +                "description": "Allow turn on/off background network events collection.",
> 
> Toggles background network event collection.

done.

>> Source/WebCore/inspector/Inspector.json:461
>> +                "name": "getBackgroundEventsCollectionState",
> 
> isBackgroundEventsCollectionEnabled

done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.