[Webkit-unassigned] [Bug 58652] Web Inspector: Background network events collection - add GUI to Inspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58652





--- Comment #29 from Pavel Feldman <pfeldman at chromium.org>  2011-05-16 08:07:21 PST ---
(From update of attachment 93638)
View in context: https://bugs.webkit.org/attachment.cgi?id=93638&action=review

> LayoutTests/http/tests/inspector/network-test.js:5
> +    if (!WebInspector.panels.network._backgroundCollectionEnabled) {

No need { }

> LayoutTests/http/tests/inspector/network-test.js:21
> +    //resources.sort(function(a, b) {return a.url.localeCompare(b.url);});

Please do not land commented code.

> LayoutTests/http/tests/inspector/network-test.js:24
> +    for (i = 0; i < resources.length; i++) {

No need for { }

> LayoutTests/http/tests/inspector/network/network-clear-after-disabled.html:32
> +        InspectorTest.evaluateInPage("frontendReopeningCount", function(result) {

Please do not use anonymous functions.

> LayoutTests/http/tests/inspector/network/network-clear-after-disabled.html:33
> +            if (result._description === "0") {

What is _description ?

> LayoutTests/http/tests/inspector/network/network-close-load-open.html:24
> +    if (loadedResourceCount === 2) {

No need for {}

> LayoutTests/http/tests/inspector/network/network-open-load-reopen.html:23
> +    if (++loadedResourceCount === 2) {

{}

> Source/WebCore/inspector/Inspector.json:455
> +                "description": "Allow turn on/off background network events collection.",

Toggles background network event collection.

> Source/WebCore/inspector/Inspector.json:461
> +                "name": "getBackgroundEventsCollectionState",

isBackgroundEventsCollectionEnabled

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.