[Webkit-unassigned] [Bug 58730] currentColor not supported in CSS gradients

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58730


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93609|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com>  2011-05-16 07:56:40 PST ---
(From update of attachment 93609)
View in context: https://bugs.webkit.org/attachment.cgi?id=93609&action=review

> LayoutTests/fast/css/linear-gradient-currentcolor.html:5
> +    color:red;

Please don't have visible red in a passing test. It would be better to use green, and maybe put two color stops next to eachother to get a sharp edge that's less likely to suffer from platform differences.

Spaces after colons please.

> Source/WebCore/ChangeLog:8
> +        https://bugs.webkit.org/show_bug.cgi?id=58730
> +
> +        Test: fast/css/linear-gradient-currentcolor.html

This needs some text saying how you fixed the issue.

> Source/WebCore/css/CSSGradientValue.cpp:159
> +            stops[i].color = renderer->document()->styleSelector()->getColorFromPrimitiveValue(color);

I don't get it. getColorFromPrimitiveValue() already looks for CSSValueCurrentcolor.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.