[Webkit-unassigned] [Bug 42759] Always freeing m_logAttrs in TextBreakIteratorGtk.cpp: setUpIterator()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42759


Jens <jens.rosenboom at eu.panasonic.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|INVALID                     |REMIND




--- Comment #6 from Jens <jens.rosenboom at eu.panasonic.com>  2011-05-16 03:09:50 PST ---
Hello All

Thank you for taking care of this.

(In reply to comment #5)
> After real tests, this bug seems to be not relevant. Freeing the memory block when necessary makes the code faster only few 0.003s faster. Now I am talking about the page having at least 20000 words in its content. I thought, Jens had a real reason, why to do this.

I just wanted someone to tell me if this (revision 71296)

213    if (createdIterator)
214        g_free(iterator->m_logAttrs);

could be replaced by this

213    g_free(iterator->m_logAttrs);

(because createdIterator is always true there) or if I missed something (e.g. createdIterator should not be set true in line 202).
I did not have performance in mind. 

> I suggest to switch this to the INVALID status. Thank you Martin!

Best regards
Jens

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.