[Webkit-unassigned] [Bug 60867] Enable strict mode for OwnPtr and PassOwnPtr

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 16 01:50:56 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=60867


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93623|                            |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Adam Barth <abarth at webkit.org>  2011-05-16 01:50:56 PST ---
(From update of attachment 93623)
View in context: https://bugs.webkit.org/attachment.cgi?id=93623&action=review

> Source/WebCore/platform/graphics/gtk/GraphicsContext3DGtk.cpp:31
> +#include "PassOwnPtr.h"

This should be

#include <wtf/PassOwnPtr.h>

> Source/WebCore/platform/graphics/gtk/GraphicsContext3DInternal.cpp:21
> +#include "PassOwnPtr.h"

This should be

#include <wtf/PassOwnPtr.h>

> Source/WebCore/platform/graphics/gtk/GraphicsContext3DInternal.cpp:94
>          return 0;

This should be "return nullptr" or else it will break soon again.  (The same applies to the other instances of "return 0" in this function.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list