[Webkit-unassigned] [Bug 60412] Page::goToItem doesn't work while loading is deferred

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60412





--- Comment #16 from Ian Henderson <ianh at apple.com>  2011-05-16 01:40:17 PST ---
(In reply to comment #14)
> (From update of attachment 92862 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=92862&action=review
> 
> > Source/WebCore/page/Page.h:407
> > +        RefPtr<HistoryItem> m_deferredItem;
> > +        FrameLoadType m_deferredFrameLoadType;
> 
> I suspect that this isn't the best place for this data.  Generally, the large "hub" objects like Frame and Page shouldn't hold much data themselves because they become "dumping grounds" for lots of unrelated stuff.  I haven't fully understood what your patch does, but these seem related to history, so perhaps the HistoryController is a more appropriate place?

Thanks for the review.  That makes a lot of sense; I'll post a patch that holds the data in HistoryController instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.