[Webkit-unassigned] [Bug 59753] Chromium Mac: Fork ScrollAnimatorMac to ScrollAnimatorChromiumMac for overlay scrollbar support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59753





--- Comment #20 from Sailesh Agrawal <sail at chromium.org>  2011-05-15 19:13:44 PST ---
(In reply to comment #19)
> How about to make ScrollAnimatorChromiumMac a subclass of  ScrollAnimatorMac
> and factor out chromium specific parts into a method and override it? 
> Forked code is really hard to maintain and I hope we didn't have more....

Currently ScrollAnimatorMac is guarded by an #if ENABLE(SMOOTH_SCROLLING). To subclass it I would have to change that to:
    #if ENABLE(SMOOTH_SCROLLING) || (PLATFORM(CHROMIUM) && OS(DARWIN))
As per comment 12 we want to avoid that.

At this point the lack of smooth scrolling is the only real difference between the Mac and Chrome version. Once we enable smooth scrolling I wouldn't even need a subclass.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.