[Webkit-unassigned] [Bug 60779] Bug in rubber banding logic for scroll animators

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60779


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93478|review?                     |review-
               Flag|                            |




--- Comment #13 from Darin Adler <darin at apple.com>  2011-05-13 13:59:45 PST ---
(From update of attachment 93478)
View in context: https://bugs.webkit.org/attachment.cgi?id=93478&action=review

Noticed the word coalesced spelled with two l's as "coalesced" in a few places.

> Source/WebCore/page/ChromeClient.h:173
> +        virtual bool shouldRubberBandInDirection(ScrollDirection) = 0;

These will need to be reimplemented for many platforms. That’s why the build of every platform except for Mac is failing.

>> Source/WebCore/page/ChromeClient.h:324
>> +        virtual void updateCountWheelEventHandlers(unsigned) = 0;
> 
> This sounds like you want the callee to update their count. I think it's really 'numWheelEventHandlersChanged()', no?

These will need to be reimplemented for many platforms. That’s why the build of every platform except for Mac is failing.

This name should probably be setWheelEventHandlerCount.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.